update to v7.3.11 by mattip · Pull Request #99 · conda-forge/pypy3.6-feedstock

mattip · 2022-12-07T12:35:14Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Part 1 of #98. Note that in the mean time CPython released security fixes for python3.8.16, python3.9.16, it may be worthwhile adding patches for those.

conda-forge-linter · 2022-12-07T12:35:18Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattip · 2022-12-07T12:35:39Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2022.12.07.11.35.54

mattip · 2022-12-08T14:49:13Z

CI is passing. Anyone care to review?

h-vetinari

CI is passing. Anyone care to review?

Not that it says much, but this LGTM :)

h-vetinari · 2022-12-10T03:35:39Z

Ah, and I was wondering about osx-arm support - it's mentioned in the announcement, but I guess it makes sense to tackle this in a separate PR. Or is cross-compilation still a ways away?

mattip · 2022-12-10T03:41:49Z

it makes sense to tackle this in a separate PR

I think so. I don't know if cross-compilation is an option since it will be very slow. I already build aarch64 and ppc64le outside CI, I could do the same for arm64. However I would want buy-in from the conda-forge team, since it would mean starting a migration for binary packages.

mattip · 2022-12-10T03:42:51Z

it makes sense to tackle this in a separate PR

xref #88

h-vetinari · 2022-12-10T03:45:56Z

I don't know if cross-compilation is an option since it will be very slow

Why should it be slow? For aarch/ppc the compilation essentially runs with native (=host) speed. What's slow is emulating one arch through another (e.g. pretend you're aarch64 while running on actual x64 hardware).

But yeah, it would need a new migration (like for pypy-windows at the time), and likely a bunch of effort to get the bootstrap and the first couple of key packages off the ground.

mattip · 2022-12-10T15:50:43Z

I think I was confused. cross-compilation (using a different compiler chain and tricking python platform, sys, os, sysconfig and other modules) is not tested and probably will not work out-of-the-box with the PyPy builds. Using qemu on x86 to emulate arm64 will be slow, which is why we build the aarch64 and ppc64le outside of CI.

mattip · 2022-12-12T12:13:49Z

This should be patched for issue 3865 so the macos-x86_64 will run on older macos<11. The patch is this commit

h-vetinari · 2023-01-06T06:56:06Z

@mattip
Could you upgrade to 7.3.11 here?

conda-forge-webservices · 2023-01-08T15:13:04Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattip · 2023-01-08T15:46:53Z

Could you upgrade to 7.3.11 here?

Done

mattip · 2023-01-08T15:48:01Z

This should be patched for issue 3865

Also done, this was the main reason for v7.3.11

mattip · 2023-01-08T15:48:46Z

CPython released security fixes for python3.8.16, python3.9.16, it may be worthwhile adding patches for those.

Also done :)

mattip · 2023-01-09T07:49:50Z

CI is passing.

Once this is merged I will build the ppc64le and aarch64 artifacts outside of CI according to this gist

h-vetinari · 2023-01-15T23:34:24Z

I think this is ready, no?

mattip · 2023-01-16T07:50:42Z

It has been a week. If no other reviewer does so before, I will merge soon and then create the other artifacts.

mattip · 2023-01-20T12:01:22Z

When trying to follow the procedure to build for aarnch64 and ppc64le I am hitting an error when rerendering.

pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '3.8.* *_cpython'

complete traceback

$ conda-smithy rerender
INFO:conda_smithy.configure_feedstock:Downloading conda-forge-pinning-2023.01.20.05.27.27
INFO:conda_smithy.configure_feedstock:Extracting conda-forge-pinning to /tmp/tmpvr_7j9ho
INFO:conda_smithy.configure_feedstock:openssl3.yaml from feedstock is ignored and upstream version is used
Setting build platform. This is only useful when pretending to be on another platform, such as for rendering necessary dependencies on a non-native platform. I tru
st that you know what you're doing.
WARNING:conda_build.config:Setting build platform. This is only useful when pretending to be on another platform, such as for rendering necessary dependencies on a
 non-native platform. I trust that you know what you're doing.
Setting build arch. This is only useful when pretending to be on another arch, such as for rendering necessary dependencies on a non-native arch. I trust that you 
know what you're doing.
WARNING:conda_build.config:Setting build arch. This is only useful when pretending to be on another arch, such as for rendering necessary dependencies on a non-nat
ive arch. I trust that you know what you're doing.
No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.16
WARNING:conda_build.metadata:No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.16
Adding in variants from internal_defaults
INFO:conda_build.variants:Adding in variants from internal_defaults
Adding in variants from /tmp/tmpvr_7j9ho/conda_build_config.yaml
INFO:conda_build.variants:Adding in variants from /tmp/tmpvr_7j9ho/conda_build_config.yaml
Adding in variants from /home/matti/pypy3.6-feedstock/recipe/conda_build_config.yaml
INFO:conda_build.variants:Adding in variants from /home/matti/pypy3.6-feedstock/recipe/conda_build_config.yaml
INFO:conda_smithy.configure_feedstock:Applying migrations: /tmp/tmpvr_7j9ho/share/conda-forge/migrations/openssl3.yaml
Adding in variants from argument_variants
INFO:conda_build.variants:Adding in variants from argument_variants
INFO:conda_smithy.configure_feedstock:Applying migrations: /tmp/tmpvr_7j9ho/share/conda-forge/migrations/openssl3.yaml
INFO:conda_smithy.configure_feedstock:Applying migrations: /tmp/tmpvr_7j9ho/share/conda-forge/migrations/openssl3.yaml
Traceback (most recent call last):
  File "/home/matti/miniconda3/envs/builder/bin/conda-smithy", line 10, in <module>
    sys.exit(main())
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_smithy/cli.py", line 670, in main
    args.subcommand_func(args)
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_smithy/cli.py", line 486, in __call__
    self._call(args, tmpdir)
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_smithy/cli.py", line 491, in _call
    configure_feedstock.main(
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_smithy/configure_feedstock.py", line 2277, in main
    render_azure(env, config, forge_dir, return_metadata=True)
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_smithy/configure_feedstock.py", line 1389, in render_azure
    return _render_ci_provider(
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_smithy/configure_feedstock.py", line 690, in _render_ci_provider
    metas = conda_build.api.render(
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/api.py", line 38, in render
    metadata_tuples = render_recipe(recipe_path, bypass_env_check=bypass_env_check,
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/render.py", line 849, in render_recipe
    rendered_metadata = distribute_variants(m, variants,
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/render.py", line 711, in distribute_variants
    used_variables = metadata.get_used_loop_vars(force_global=False)
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/metadata.py", line 2558, in get_used_loop_vars
    for var in self.get_used_vars(
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/metadata.py", line 2661, in get_used_vars
    meta_yaml_reqs = self._get_used_vars_meta_yaml(
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/metadata.py", line 2746, in _get_used_vars_meta_yaml
    reqs_text, recipe_text = self._get_used_vars_meta_yaml_helper(
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/metadata.py", line 2714, in _get_used_vars_meta_yaml_helper
    recipe_text = self.get_recipe_text(
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/metadata.py", line 2013, in get_recipe_text
    ns_cfg(self.config),
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/metadata.py", line 102, in ns_cfg
    defaults = variants.get_default_variant(config)
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/variants.py", line 109, in get_default_variant
    base.update(_get_default_compilers(config.platform, python))
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/conda_build/variants.py", line 90, in _get_default_compilers
    if parse_version(py_ver) >= parse_version('3.5'):
  File "/home/matti/miniconda3/envs/builder/lib/python3.9/site-packages/pkg_resources/_vendor/packaging/version.py", line 266, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '3.8.* *_cpython'
``

mattip · 2023-01-20T12:51:39Z

The error above is on aarch64. On ppc64le that error is a warning.

mattip · 2023-01-22T08:13:15Z

Starting over from an updated base environment seems to have allowed the build process to complete.

mattip · 2023-01-25T21:58:17Z

@isuruf the conda-forge-p8-1 machine is out of disk space. Is there a way to clean up something there or to get a larger disk?

mattip · 2023-01-26T13:27:08Z

@beckermr do you known anything about the ppc64le conda-forge-p8-1 machine? It does not have enough disk space to allow me to build the ppc64le packages for this feedstock, as I have been able to do in the past following this gist. The builds are too slow to use a cross-compilation workflow.

isuruf · 2023-01-26T22:30:05Z

Cleaned up the VM. Have a look now.

mattip · 2023-01-31T22:02:21Z

I uploaded ppc64le and aarch64 tarballs to https://anaconda.org/mattip/pypy3.8/files and https://anaconda.org/mattip/pypy3.9/files and marked them with the "copy" label. There should be 4 files in each location.

Here are the build logs

ppc64le-logs.txt
aarch64-logs.txt

xref @isuruf could you copy the files to https://anaconda.org/conda-forge/pypy3.8 and https://anaconda.org/conda-forge/pypy3.9 ?

isuruf · 2023-02-01T04:43:13Z

Done

mattip · 2023-02-01T06:23:52Z

Thanks!

update to v7.3.10

a59d2ae

mattip requested review from isuruf, ocefpaf, ohadravid and omerbenamram as code owners December 7, 2022 12:35

conda-forge-webservices[bot] and others added 2 commits December 7, 2022 12:37

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

773ac95

…nda-forge-pinning 2022.12.07.11.35.54

redo patch differently

84a6d1f

mattip force-pushed the v7.3.10 branch from f88e43c to 84a6d1f Compare December 7, 2022 13:25

mattip added 2 commits December 7, 2022 16:12

disable obsolete NPN

1fbe9be

format patch correctly

4d3a31b

mattip force-pushed the v7.3.10 branch from 21a40cc to 046dddf Compare December 8, 2022 12:02

fix packaging logic around tkinter

06444b8

mattip force-pushed the v7.3.10 branch from 046dddf to 06444b8 Compare December 8, 2022 12:04

h-vetinari approved these changes Dec 10, 2022

View reviewed changes

patch for macos-86_64 and macos<11

252d3f3

mattip mentioned this pull request Jan 8, 2023

V7.3.11 #100

Closed

5 tasks

mattip added 2 commits January 8, 2023 17:04

use pypy7.3.11, adjust patches

044d828

fix patches

d403cb3

fix bad merges from cherry-picking commits in conda-forge#100

080f003

remove unneeded patches

87e931c

mattip changed the title ~~update to v7.3.10~~ update to v7.3.11 Jan 8, 2023

mattip mentioned this pull request Jan 8, 2023

Update to PyPy 3.8.16, PyPy 3.9.16 conda-forge/pypy-meta-feedstock#26

Closed

mattip added 3 commits January 9, 2023 02:20

fix tk link libraries

559e8eb

fix patch

73ca5bd

mark patch for removal in next version

b185941

mattip merged commit ef1ddd8 into conda-forge:main Jan 18, 2023

This was referenced Jan 27, 2023

Re-enable pypy conda-forge/scipy-feedstock#208

Merged

Update to 7.3.11; remove duplicated CI jobs conda-forge/pypy-meta-feedstock#24

Merged

Pypy mac M1 support #88

Open

h-vetinari mentioned this pull request Aug 29, 2023

V7.3.12 #105

Merged

5 tasks

Uh oh!

Uh oh!

Conversation

mattip commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-linter commented Dec 7, 2022

Uh oh!

mattip commented Dec 7, 2022

Uh oh!

mattip commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

h-vetinari left a comment

Choose a reason for hiding this comment

Uh oh!

h-vetinari commented Dec 10, 2022

Uh oh!

mattip commented Dec 10, 2022

Uh oh!

mattip commented Dec 10, 2022

Uh oh!

h-vetinari commented Dec 10, 2022

Uh oh!

mattip commented Dec 10, 2022

Uh oh!

mattip commented Dec 12, 2022

Uh oh!

h-vetinari commented Jan 6, 2023

Uh oh!

conda-forge-webservices Bot commented Jan 8, 2023

Uh oh!

mattip commented Jan 8, 2023

Uh oh!

mattip commented Jan 8, 2023

Uh oh!

mattip commented Jan 8, 2023

Uh oh!

mattip commented Jan 9, 2023

Uh oh!

h-vetinari commented Jan 15, 2023

Uh oh!

mattip commented Jan 16, 2023

Uh oh!

mattip commented Jan 20, 2023

Uh oh!

mattip commented Jan 20, 2023

Uh oh!

mattip commented Jan 22, 2023

Uh oh!

mattip commented Jan 25, 2023 • edited by isuruf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattip commented Jan 26, 2023 • edited by isuruf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isuruf commented Jan 26, 2023

Uh oh!

mattip commented Jan 31, 2023

Uh oh!

isuruf commented Feb 1, 2023

Uh oh!

mattip commented Feb 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mattip commented Dec 7, 2022 •

edited

Loading

mattip commented Dec 8, 2022 •

edited

Loading

mattip commented Jan 25, 2023 •

edited by isuruf

Loading

mattip commented Jan 26, 2023 •

edited by isuruf

Loading